Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure @nx/module-federation is listed in package group #29292

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 10, 2024

Current Behavior

@nx/module-federation is not listed in the nx package's packageGroup.
This reports it incorrectly in nx report and can impact nx migrate.

Expected Behavior

@nx/module-federation should be listed in the packageGroup

@Coly010 Coly010 requested a review from a team as a code owner December 10, 2024 17:43
@Coly010 Coly010 self-assigned this Dec 10, 2024
@Coly010 Coly010 requested a review from AgentEnder December 10, 2024 17:43
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 5:47pm

@Coly010 Coly010 enabled auto-merge (squash) December 10, 2024 17:48
@Coly010 Coly010 merged commit be2eab9 into master Dec 10, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation/ensure-listed-as-official branch December 10, 2024 18:20
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
…29292)

## Current Behavior
`@nx/module-federation` is not listed in the `nx` package's
`packageGroup`.
This reports it incorrectly in `nx report` and can impact `nx migrate`.

## Expected Behavior
`@nx/module-federation` should be listed in the `packageGroup`

(cherry picked from commit be2eab9)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants