Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): not generate tsconfig if already exists #29317

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Dec 12, 2024

Current Behavior

  • in serve target, it uses executor @nx/webpack:dev-server
  • in packages/webpack/src/executors/dev-server/dev-server.impl.ts, when buildLibsFromSource is false, it calls createTmpTsConfig to create a temp config
  • in webpack.config.js, it has module.exports = composePlugins(withNx(). in withNx, it calls NxTsconfigPathsWebpackPlugin.
  • when buildLibsFromSource is false, it called createTmpTsConfig again based on the temp config. it created an infinite loop because it creates a tsconfig that extends itself.

Expected Behavior

  • do not create a temp config if it is a generated ts config

Related Issue(s)

Fixes #28006

@xiongemi xiongemi requested a review from a team as a code owner December 12, 2024 02:08
@xiongemi xiongemi requested a review from jaysoo December 12, 2024 02:08
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Dec 12, 2024 2:08am

@xiongemi xiongemi merged commit 81c66ec into master Dec 20, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/not-generate-ts-config-if-exists branch December 20, 2024 18:10
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants