feat(core): show progress on ci if graph construction takes longer than expected #29392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 2c7b2f8.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
requested changes
Dec 18, 2024
|
|
||
| /** | ||
| * Constructs a new {@link DelayedSpinner} instance. | ||
| * | ||
| * @param message The message to display in the spinner | ||
| * @param ms The number of milliseconds to wait before creating the spinner | ||
| */ | ||
| constructor(message: string, ms: number = 500) { | ||
| constructor(message: string, ms?: number); |
There was a problem hiding this comment.
Is this used? If not, let's get rid of this signature.
| @@ -62,4 +98,4 @@ export class DelayedSpinner { | |||
| } | |||
| } | |||
|
|
|||
| export const SHOULD_SHOW_SPINNERS = process.stdout.isTTY; | |||
| export const SHOULD_SHOW_SPINNERS = process.stdout.isTTY && !isCI(); | |||
There was a problem hiding this comment.
This doesn't need to be exported anymore right?
FrozenPandaz
requested changes
Dec 18, 2024
| @@ -64,7 +64,7 @@ export class DelayedSpinner { | |||
| if (this.spinner && SHOULD_SHOW_SPINNERS) { | |||
| this.spinner.text = message; | |||
| } else if (this.lastMessage && this.lastMessage !== message) { | |||
| console.log(message); | |||
| console.error(message); | |||
There was a problem hiding this comment.
A warning is probably better?
AgentEnder
force-pushed
the
feat/ci-progress-indicator
branch
from
ed64efb to
0df7ef5
Compare
AgentEnder
force-pushed
the
feat/ci-progress-indicator
branch
from
0df7ef5 to
2c7b2f8
Compare
FrozenPandaz
approved these changes
Dec 19, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
…an expected (#29392) Progress spinners currently only show up when the terminal is a tty. This updates it to show static text on CI, but at a longer duration
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress spinners currently only show up when the terminal is a tty. This updates it to show static text on CI, but at a longer duration