-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): lock graph creation when running in another process #29408
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 73bb882.
☁️ Nx Cloud last updated this comment at |
d1f6a60
to
8bb1c07
Compare
8bb1c07
to
d14b40b
Compare
d14b40b
to
41b174c
Compare
0204e02
to
beff91a
Compare
beff91a
to
b44f168
Compare
16db699
to
7c67700
Compare
7c67700
to
78836c3
Compare
78836c3
to
ca21cbf
Compare
ca21cbf
to
73bb882
Compare
Failed to publish a PR release of this pull request, triggered by @AgentEnder. |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29408-73bb882
To request a new release for this pull request, mention someone from the Nx team or the |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Running Nx in multiple processes at the same time with the daemon disabled can cripple a system due to excess memory usage when creating the graph. This is due to plugin workers being started per-parent process when there is no daemon. This change enables a file lock to prevent the simultaneous processing, and read from the cache when the first run completes.
Currently, running
nx show projects
30 times in parallel looks something like this:30 processes exited within 37535ms
Expected Behavior
30 processes exited within 6435ms
Test Script