Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rsbuild): move plugin export to root of package #29415

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 19, 2024

Current Behavior

The Rsbuild plugin is exported at @nx/rsbuild/plugin

Expected Behavior

Export the plugin from @nx/rsbuild i.e. the root of the package.

@Coly010 Coly010 requested review from a team as code owners December 19, 2024 10:02
@Coly010 Coly010 self-assigned this Dec 19, 2024
@Coly010 Coly010 requested a review from ndcunningham December 19, 2024 10:02
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 10:04am

Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit 54c0c11.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 7s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=2eb52... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 17s View ↗
nx documentation --no-dte ✅ Succeeded 38s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 10:38:19 UTC

@Coly010 Coly010 merged commit 2db82dd into master Dec 19, 2024
6 checks passed
@Coly010 Coly010 deleted the rsbuild/move-plugin-to-root branch December 19, 2024 14:09
ndcunningham pushed a commit that referenced this pull request Dec 20, 2024
## Current Behavior
The Rsbuild plugin is exported at `@nx/rsbuild/plugin`


## Expected Behavior
Export the plugin from `@nx/rsbuild` i.e. the root of the package.
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants