fix(release): invalid config path in hint for using skipLockFileUpdate #29425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 5988017.
☁️ Nx Cloud last updated this comment at |
JamesHenry
requested changes
Dec 23, 2024
Nx hint message is wrong "To disable this step entirely, set 'release.version.skipLockFileUpdate' to true in nx.json." It is now, "To disable this step entirely, set 'release.version.generatorOptions.skipLockFileUpdate' to true in nx.json."
JamesHenry
approved these changes
Dec 23, 2024
JamesHenry
changed the title
|
Thank you! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
nx release versionfails on updating lock file, the hint with invalid config path is displayed.It says:
To disable this step entirely, set 'release.version.skipLockFileUpdate' to true in nx.json.
Expected Behavior
It should say:
To disable this step entirely, set 'release.version.generatorOptions.skipLockFileUpdate' to true in nx.json.
Related Issue(s)
Fixes #