fix(js): infer outputs correctly when both rootDir and outDir are set for tsconfig #29531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 98feea3.
☁️ Nx Cloud last updated this comment at |
leosvelperez
reviewed
Jan 7, 2025
leosvelperez
approved these changes
Jan 7, 2025
Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
jaysoo
force-pushed
the
fix/tsbuildinfo-outputs
branch
from
aa67977 to
98feea3
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 7, 2025
… for tsconfig (#29531) When the tsconfig has `rootDir` and `outDir` both defined, then the `*.tsbuildinfo` file is not cached. This makes incremental tsc not work through distribution (e.g. agents). For example, given this `tsconfig.lib.json` file: ```json { "compilerOptions": { "outDir": "out-tsc/lib-1", "rootDir": "src" } } ``` The outputs (e.g. `*.d.ts` files) are under `{projectRoot}/out-tsc/lib-1`, but the tsbuild info file is under `{projectRoot}/out-tsc/tsconfig.lib.tsbuildinfo`. ## Current Behavior tsbuildinfo file is not cached ## Expected Behavior tsbuildinfo file is cached ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Leosvel Pérez Espinosa <[email protected]> (cherry picked from commit df27a97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tsconfig has
rootDirandoutDirboth defined, then the*.tsbuildinfofile is not cached. This makes incremental tsc not work through distribution (e.g. agents).For example, given this
tsconfig.lib.jsonfile:{ "compilerOptions": { "outDir": "out-tsc/lib-1", "rootDir": "src" } }The outputs (e.g.
*.d.tsfiles) are under{projectRoot}/out-tsc/lib-1, but the tsbuild info file is under{projectRoot}/out-tsc/tsconfig.lib.tsbuildinfo.Current Behavior
tsbuildinfo file is not cached
Expected Behavior
tsbuildinfo file is cached
Related Issue(s)
Fixes #