fix(misc): ensure exports are generated for several lib generators in ts solution setup
#29588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 801aef7.
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
misc/generate-exports-lib-generators
branch
from
296a4b6 to
909157b
Compare
jaysoo
force-pushed
the
misc/generate-exports-lib-generators
branch
from
909157b to
4460525
Compare
jaysoo
approved these changes
Jan 10, 2025
jaysoo
force-pushed
the
misc/generate-exports-lib-generators
branch
from
4460525 to
549ec68
Compare
…in ts solution setup
jaysoo
force-pushed
the
misc/generate-exports-lib-generators
branch
from
549ec68 to
801aef7
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
…in ts solution setup (#29588) - Update React Native, React, Remix and Vue library generators to produce `exports` in the `package.json` for the TS solution setup - Fix an issue in `@nx/rollup/with-nx` where an unhandled `undefined` plugin was causing an error to be thrown - Fix output path of the build task for React Native libraries in the TS solution setup <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 9dbebbe)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportsin thepackage.jsonfor the TS solution setup@nx/rollup/with-nxwhere an unhandledundefinedplugin was causing an error to be thrownCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #