Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add convert-to-rspack generator #29860

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 3, 2025

Current Behavior

Nx currently does not offer an automated method for switching from an Angular Webpack build to an Angular Rspack build.

Expected Behavior

Provide a generator convert-to-rspack in @nx/angular that will allow conversion from an Angular Webpack build to an Angular Rspack build.

Usage: nx g convert-to-rspack --project=myapp

@Coly010 Coly010 self-assigned this Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 10, 2025 9:58am

Copy link

nx-cloud bot commented Feb 3, 2025

View your CI Pipeline Execution ↗ for commit 9bb61d3.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 25m 15s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 23s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 8s View ↗
nx documentation ✅ Succeeded 1m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-10 10:20:08 UTC

};
const buildAndServeTargetNames: string[] = [];

for (const [targetName, target] of Object.entries(project.targets)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, add a validation check before to print a warning in case none of the executors are present. In case a user is trying to convert a project with custom executors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there is a lot more that needs to go into this generator.

it’s still in draft for now to reflect this status

Copy link

github-actions bot commented Feb 4, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-43e1fcb
Release details 📑
Published version 0.0.0-pr-29860-43e1fcb
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 43e1fcb
Workflow run 13133852282

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants