-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): add convert-to-rspack generator #29860
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 9bb61d3.
☁️ Nx Cloud last updated this comment at |
}; | ||
const buildAndServeTargetNames: string[] = []; | ||
|
||
for (const [targetName, target] of Object.entries(project.targets)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, add a validation check before to print a warning in case none of the executors are present. In case a user is trying to convert a project with custom executors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is a lot more that needs to go into this generator.
it’s still in draft for now to reflect this status
60af78b
to
43e1fcb
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29860-43e1fcb
To request a new release for this pull request, mention someone from the Nx team or the |
43e1fcb
to
9bb61d3
Compare
Current Behavior
Nx currently does not offer an automated method for switching from an Angular Webpack build to an Angular Rspack build.
Expected Behavior
Provide a generator
convert-to-rspack
in@nx/angular
that will allow conversion from an Angular Webpack build to an Angular Rspack build.Usage:
nx g convert-to-rspack --project=myapp