feat(testing): disable jest runtime by default when inferring targets #29917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 81bfeeb.
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
feat/disable-jest-runtime
branch
4 times, most recently
from
5bf8645 to
f00e59c
Compare
FrozenPandaz
requested changes
Feb 7, 2025
jaysoo
force-pushed
the
feat/disable-jest-runtime
branch
from
f00e59c to
f1f2000
Compare
jaysoo
force-pushed
the
feat/disable-jest-runtime
branch
from
f1f2000 to
81bfeeb
Compare
FrozenPandaz
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
@nx/jest/pluginsuch thatdisableJestRuntimeoption is true by default. Users will need to set it to false to bring injest-configandjest-runtimeto compute atomized targets. We're leaving it as an option if anyone runs into discrepancies between our calculation and what jest-runtime calculates for test files within a project.Current Behavior
Jest runtime is used by default and is potentially slow if you use many transforms, presets, etc. in the jest config.
Expected Behavior
Jest runtime is not used by default, and users have to option of enabling it.
Related Issue(s)
Fixes #