Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): use @ngrx/schematics #386

Closed
wants to merge 1 commit into from
Closed

feat(schematics): use @ngrx/schematics #386

wants to merge 1 commit into from

Conversation

ThomasBurleson
Copy link
Contributor

  • ngrx collection now extends @ngrx/schematics
  • modify the nrwl ngrx schematic to use @ngrx/schematics to generate the initial source for actions, reducers, and effects
  • modify the generated source to conform to Nx standards
  • generate init and interface files
  • remove template files for action, effect, and reducer scaffolding
  • modify collection to extend @ngrx/schematics so the ngrx commands are also easily accessible
  • inject dataloaded enums into action class
  • configure nx workspace devDep on @ngrx/schematics version
  • override ngrx effects.spec.ts with nx templated version

fixes #174.

* ngrx collection now extends @ngrx/schematics
* modify the nrwl `ngrx` schematic to use `@ngrx/schematics` to generate the initial source for actions, reducers, and effects
* modify the generated source to conform to Nx standards
* generate init and interface files
* remove template files for action, effect, and reducer scaffolding
* modify collection to extend `@ngrx/schematics` so the ngrx commands are also easily accessible
* inject dataloaded enums into action class
* configure nx workspace devDep on @ngrx/schematics version
* override ngrx effects.spec.ts with nx templated version

fixes #174.
@vsavkin
Copy link
Member

vsavkin commented Mar 30, 2018

Merged here: 4edc8e6

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up NgRx schematic
2 participants