fix: issue when adding media via media library with multiple editor i…

…nstances, closes #175
nshenderov · Nov 5, 2024 · ce46033 · ce46033
1 parent 217e1fe
commit ce46033
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 25 deletions.
diff --git a/admin/src/components/Input/components/Editor.jsx b/admin/src/components/Input/components/Editor.jsx
@@ -41,24 +41,12 @@ export const Editor = ({
 
   useEffect(() => {
     (async () => {
-      const currentPreset = await getConfiguredPreset(
-        presetName,
-        handleToggleMediaLib
-      );
-
-      if (placeholder) {
-        const clonedPreset = {
-          ...currentPreset,
-          editorConfig: {
-            ...currentPreset.editorConfig,
-            placeholder: placeholder,
-          },
-        };
-
-        setPreset(clonedPreset);
-      } else {
-        setPreset(currentPreset);
-      }
+      const currentPreset = await getConfiguredPreset(presetName, {
+        toggleMediaLib: handleToggleMediaLib,
+        strapiFieldPlaceholder: placeholder,
+      });
+
+      setPreset(currentPreset);
     })();
   }, []);
 

diff --git a/admin/src/components/Input/config/presets.js b/admin/src/components/Input/config/presets.js
@@ -2,17 +2,27 @@ import basePresets from '../presets';
 import { setPlugins } from './plugins';
 import { setLanguage } from './language';
 
-export const getConfiguredPreset = async (presetName, toggleMediaLib) => {
+export const getConfiguredPreset = async (
+  presetName,
+  { toggleMediaLib, strapiFieldPlaceholder }
+) => {
   const { presets: userPresets, dontMergePresets } =
     globalThis.SH_CKE_CONFIG || {};
 
-  const preset = dontMergePresets
-    ? userPresets[presetName]
-    : basePresets[presetName];
+  const preset =
+    dontMergePresets ? userPresets[presetName] : basePresets[presetName];
 
-  setPlugins(preset.editorConfig, toggleMediaLib);
+  const clonedPreset = {
+    ...preset,
+    editorConfig: {
+      ...preset.editorConfig,
+      placeholder: strapiFieldPlaceholder || preset.editorConfig.placeholder,
+    },
+  };
 
-  await setLanguage(preset.editorConfig);
+  setPlugins(clonedPreset.editorConfig, toggleMediaLib);
 
-  return preset;
+  await setLanguage(clonedPreset.editorConfig);
+
+  return clonedPreset;
 };