upgrade ckeditor to latest 37.1.0 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nshenderov any chances of reviewing this? |
|
@nshenderov Giving this a bump! Custom CKEditor plugin implementation is one of the few things we definitely need to be able to adopt this custom field. |
|
When do @nshenderov release a new version that depends on the latest version of CKEditor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I upgraded the ckeditor version from 36.0.1 to latest 37.1.0
I tested this on Strapi 4.9.2 following the Contribution Guide.
For the contribution guide to work I had also to:
yarn uninstall @_sh/strapi-plugin-ckeditor)This will avoid the conflict at runtime between CKEditor 36.0.1 and 37.1.0
Why is it needed?
The latest 37.x release of CKEditor 5 is a full rewrite in TypeScript that introduces several bugfixes. TypeScript makes it easier and more consistent to deal with CKEditor typings and interfaces.
Finally, the latest stable CKeditor 5 stable 1.0.0 version released yesterday leverages 37.1.x typings. This means integrating custom CKEditor plugins into Strapi and CKeditor should be easy now.
Related issue(s)/PR(s)
Solves #102
I hope this gets merged soon since I have to deal with several custom plugins. Thanks