#15 language content implementation ready. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshenderov
requested changes
Jul 7, 2022
Comment on lines
81
to
87
| //set locale language code to content | ||
| let language = editor.language; | ||
| if (languageContent) { | ||
| const countryCode = languageContent.split("-")[0] | ||
| if (countryCode) | ||
| language = { content: editor.language.content ? editor.language.content : countryCode, ui: editor.language.ui, textPartLanguage: editor.textPartLanguage } | ||
| } |
There was a problem hiding this comment.
@zadinvit Hi, thank you for your pr.
I think we need some changes here:
let language = editor.language;
if (languageContent) {
const countryCode = languageContent.split("-")[0]
if (countryCode && language)
language = {
content: language.content || countryCode,
ui: typeof language === "string" && language || language.ui || auth.getUserInfo().preferedLanguage,
textPartLanguage: language.textPartLanguage
}
}And this should be inside if(editor) statement below
There was a problem hiding this comment.
Hi,
I agree with you. I move your changes to my code at my branch tomorow. Thanks for improve my code.
|
@nshenderov I merge you changes to code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I create support for dynamically change content type by i18n language #15. If user set up content, it will use config content. I think this can't broke anything else. It's just reads country name from query params.