add CGO_ENABLED=0

[kmlebedev]

disable glibc dependency

#58

[nsmithuk]

Hi @kmlebedev

Unless something has changed since the feature was added, glibc is unfortunately needed to support the ECC_SECG_P256K1 key type. There wasn't any suitable native Go implementations, so I had to use https://github.com/btcsuite/btcd, which does/did need glibc.

We could circle back and see if that's still the case, but I'd want to confirm before merging this.

[tristanmorgan]

I tested with a build using CGO_ENABLED=0 on Go 1.23.2 and there doesn't seem to have a dependancy on CGO anymore.

response from local-kms when creating an ecc_secg_p256k1
INFO[2024-10-11 10:37:14.791] New ECC_SECG_P256K1 key created: arn:aws:kms:ap-southeast-2:123456789012:key/5990917a-6114-48a5-9c47-d3b42d468b7c

{
  "key_metadata": {
    "aws_account_id": "123456789012",
    "key_id": "5990917a-6114-48a5-9c47-d3b42d468b7c",
    "arn": "arn:aws:kms:ap-southeast-2:123456789012:key/5990917a-6114-48a5-9c47-d3b42d468b7c",
    "creation_date": "2024-10-11 10:37:14 +1100",
    "enabled": true,
    "key_usage": "SIGN_VERIFY",
    "key_state": "Enabled",
    "origin": "AWS_KMS",
    "key_manager": "CUSTOMER",
    "customer_master_key_spec": "ECC_SECG_P256K1",
    "key_spec": "ECC_SECG_P256K1",
    "signing_algorithms": [
      "ECDSA_SHA_256"
    ]
  }
}

[nsmithuk]

Thanks @tristanmorgan. I'll try and do some of my own testing with this at the weekend. Hopefully we can get this merged!