Merge pull request #243 from jehiah/is_starved_243

limit reader.IsStarved() to active connections
nsqio · Aug 6, 2013 · 1154c59 · 1154c59
2 parents 902cfb4 + 13665ab
commit 1154c59
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/nsq/reader.go b/nsq/reader.go
@@ -295,8 +295,8 @@ func (q *Reader) IsStarved() bool {
 
 	for _, conn := range q.nsqConnections {
 		threshold := int64(float64(atomic.LoadInt64(&conn.lastRdyCount)) * 0.85)
-		if atomic.LoadInt64(&conn.messagesInFlight) >= threshold &&
-			atomic.LoadInt32(&conn.stopFlag) != 1 {
+		inFlight := atomic.LoadInt64(&conn.messagesInFlight)
+		if inFlight >= threshold && inFlight > 0 && atomic.LoadInt32(&conn.stopFlag) != 1 {
 			return true
 		}
 	}