Merge pull request #505 from iand/master

util: speed up failure path of ByteToBase10

util/byte_base10.go

@@ -4,6 +4,8 @@ import (
 	"errors"
 )
 
+var base10fail = errors.New("failed to convert to Base10")
+
 func ByteToBase10(b []byte) (n uint64, err error) {
 	base := uint64(10)
 
@@ -16,8 +18,8 @@ func ByteToBase10(b []byte) (n uint64, err error) {
 			v = d - '0'
 		default:
 			n = 0
-			err = errors.New("failed to convert to Base10")
-			break
+			err = base10fail
+			return
 		}
 		n *= base
 		n += uint64(v)

util/byte_base10_test.go

@@ -0,0 +1,25 @@
+package util
+
+import (
+	"testing"
+)
+
+var result uint64
+
+func BenchmarkByteToBase10Valid(b *testing.B) {
+	bt := []byte{'3', '1', '4', '1', '5', '9', '2', '5'}
+	var n uint64
+	for i := 0; i < b.N; i++ {
+		n, _ = ByteToBase10(bt)
+	}
+	result = n
+}
+
+func BenchmarkByteToBase10Invalid(b *testing.B) {
+	bt := []byte{'?', '1', '4', '1', '5', '9', '2', '5'}
+	var n uint64
+	for i := 0; i < b.N; i++ {
+		n, _ = ByteToBase10(bt)
+	}
+	result = n
+}