-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nsqd: arbitrary 1 hour limit for REQ timeout #348
Comments
Chosen arbitrarily 😁 I would be amenable to a pull request that made it configurable. |
personally I wouldn't mind seeing the upper limits removed completely, but I can see how they would be handy for typos :D |
I like the idea of things being bounded (where possible), but configurable. This was just an oversight and I'm fine with making it configurable. I think it's always better if the user chooses a higher limit for something while packaged with a sane but opinionated default. |
see #352 |
nsqd: Make REQ timeout limit configurable Fixes #348
@mreiferson We (I and @AlphaB) would be very grateful if you make a next patch release with this fix. |
@AlekSi definitely, we're figuring out what we want in the next release... soon 😁 |
@mreiferson I mean, if you are going to make a big release, please make a small one with this one small sweet fix before, it will make our life a lot easier. |
@AlekSi duly noted. I'm not sure I even want to know why you want to requeue things for more than an hour though! 😄 |
As workaround for #293 (support deferred PUB). |
@mreiferson Execuse me, but would you mind to explain why one hour is a "a sane default"? |
@liaojianqi the use-case nsq targets is a "A realtime distributed messaging platform". p.s. please use forums other than 5 year old closed issues to discuss details of nsq. |
May it be increased?
The text was updated successfully, but these errors were encountered: