Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsqd: arbitrary 1 hour limit for REQ timeout #348

Closed
AlekSi opened this issue May 20, 2014 · 11 comments · Fixed by #352
Closed

nsqd: arbitrary 1 hour limit for REQ timeout #348

AlekSi opened this issue May 20, 2014 · 11 comments · Fixed by #352

Comments

@AlekSi
Copy link
Contributor

AlekSi commented May 20, 2014

May it be increased?

@mreiferson
Copy link
Member

Chosen arbitrarily 😁

I would be amenable to a pull request that made it configurable.

@tj
Copy link
Contributor

tj commented May 20, 2014

personally I wouldn't mind seeing the upper limits removed completely, but I can see how they would be handy for typos :D

@mreiferson
Copy link
Member

I like the idea of things being bounded (where possible), but configurable. This was just an oversight and I'm fine with making it configurable.

I think it's always better if the user chooses a higher limit for something while packaged with a sane but opinionated default.

@mreiferson mreiferson changed the title REQ: why upper limit for timeout is 1 hour? nsqd: arbitrary 1 hour limit for REQ timeout May 21, 2014
@mreiferson
Copy link
Member

see #352

mreiferson added a commit that referenced this issue May 23, 2014
nsqd: Make REQ timeout limit configurable Fixes #348
@AlekSi
Copy link
Contributor Author

AlekSi commented May 27, 2014

@mreiferson We (I and @AlphaB) would be very grateful if you make a next patch release with this fix.

@mreiferson
Copy link
Member

@AlekSi definitely, we're figuring out what we want in the next release... soon 😁

@AlekSi
Copy link
Contributor Author

AlekSi commented May 27, 2014

@mreiferson I mean, if you are going to make a big release, please make a small one with this one small sweet fix before, it will make our life a lot easier.

@mreiferson
Copy link
Member

@AlekSi duly noted. I'm not sure I even want to know why you want to requeue things for more than an hour though! 😄

@AlekSi
Copy link
Contributor Author

AlekSi commented May 27, 2014

As workaround for #293 (support deferred PUB).

@liaojianqi
Copy link

@mreiferson Execuse me, but would you mind to explain why one hour is a "a sane default"?

@jehiah
Copy link
Member

jehiah commented May 14, 2019

@liaojianqi the use-case nsq targets is a "A realtime distributed messaging platform".

p.s. please use forums other than 5 year old closed issues to discuss details of nsq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants