Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: replace sort.Sort with sort.Ints #1206

Merged
merged 1 commit into from
Oct 29, 2019
Merged

nsqd: replace sort.Sort with sort.Ints #1206

merged 1 commit into from
Oct 29, 2019

Conversation

lelenanam
Copy link
Contributor

Fix staticcheck issue

@ploxiln
Copy link
Member

ploxiln commented Oct 28, 2019

I see the same pattern in nsqd/in_flight_pqueue_test.go, want to take care of that one too?

@lelenanam
Replace sort.Sort with sort.Ints
430e90b 
Fix staticcheck issue
@lelenanam
Copy link
Contributor Author

Sure, I fixed sort.Sort in the test.
Not sure why it fails now, looks unrelated. Maybe let's just retry?

@ploxiln
Copy link
Member

ploxiln commented Oct 29, 2019

Yeah, was a spurious/flaky failure, unfortunately, in 1 of the 6 test configs. I restarted it and it indeed passed.

@ploxiln ploxiln merged commit dbfb2d8 into nsqio:master Oct 29, 2019
@mreiferson mreiferson changed the title Replace sort.Sort with sort.Ints nsqd: replace sort.Sort with sort.Ints Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lelenanam @ploxiln @mreiferson