nsqd: close connections on exit (without another map) #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
force-pushed
the
nsqd-client-close
branch
from
045203e to
55cd47e
Compare
|
Looks great :) It does look like nsqlookupd could use similar treatment. |
ploxiln
approved these changes
Jul 26, 2020
mreiferson
force-pushed
the
nsqd-client-close
branch
from
55cd47e to
02e4247
Compare
ploxiln
reviewed
Nov 21, 2020
ploxiln
reviewed
Nov 21, 2020
|
@ploxiln I don't remember what I was trying to do here with the latest commit 😬, so I'll ping when it's ready for review. |
mreiferson
force-pushed
the
nsqd-client-close
branch
2 times, most recently
from
d6a79f6 to
58a5dac
Compare
|
alright I think this is ready |
ploxiln
approved these changes
Dec 30, 2020
|
(tested a bit locally too, seems to work) |
mreiferson
force-pushed
the
nsqd-client-close
branch
2 times, most recently
from
78c5ac1 to
cc3d7e1
Compare
jehiah
approved these changes
Jan 31, 2021
|
Wow, that GitHub feature to "commit suggestion" is 😍 PTAL |
mreiferson
force-pushed
the
nsqd-client-close
branch
from
2e86e20 to
11b3d89
Compare
|
squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the backlog of PRs that have landed, I propose a simpler alternative to #1198, which fixes a bug introduced in #1190.
We're already tracking all client connections, including producers in
nsqd.clients, so let's just use it to trigger connection close on exit.Note: we should probably do this consistently across
nsqdandnsqlookupdw/r/t what struct owns tracking and closing client conns, so maybe I should make a similar set of changes tonsqlookupd.cc @ploxiln