*: update and fix benchmark script #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
reviewed
Jun 15, 2020
bench/bench.py
Outdated
| @@ -250,30 +257,22 @@ def run(): | |||
| max_duration / total_ops * 1000 * 1000) | |||
|
|
|||
| for ssh_client, chan in nsqd_chans: | |||
| chan.close() | |||
| if hasattr(chan, 'close'): | |||
There was a problem hiding this comment.
agreed, missed that change, updated
ploxiln
reviewed
Jun 15, 2020
bench/bench.py
Outdated
| help='AMI ID') | ||
| tornado.options.define('ssh_key_name', type=str, default='default', | ||
| help='SSH key name') | ||
| tornado.options.define('instance_type', type=str, default='c3.2xlarge', | ||
| tornado.options.define('instance_type', type=str, default='c3.xlarge', |
There was a problem hiding this comment.
may I suggest c5.large
(which would also require changing the AMI to an HVM-EBS variant, I think ami-0ac80df6eff0e70b5 would do it, and maybe instance-create would then need a root-ebs-size parameter)
... but this could be updated in a separate PR, I could try that after this is merged
There was a problem hiding this comment.
c5.large is VPC-only, so until we rewrite it to setup an entire VPC (not likely), this is Good Enough ™️
I didn't mean to change this from the original default, I'll update it.
ploxiln
approved these changes
Jun 15, 2020
mreiferson
force-pushed
the
fix-benchmark-script
branch
from
3976eae to
7c4e954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1204
fixes #1202
cc @martingrambow @ploxiln