internal: optimized uniq function #1289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I optimized the function body of stringy.Uniq to get rid of the boolean allocation.
I applied B and A testing to the optimized and previous version.
Last benchmark result:
goos: linux
goarch: amd64
pkg: github.com/nsqio/nsq/internal/stringy
BenchmarkUniq (Old version)
BenchmarkUniq-16 125957919 96.8 ns/op 48 B/op 2 allocs/op
BenchmarkUniqB (New version)
BenchmarkUniqB-16 142343587 91.5 ns/op 48 B/op 2 allocs/op