nsqd: client configurable output buffering #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff is ugly, sorry... if we can come up with a shorter name for "OutputBuffer" |
|
how about |
|
I like the term |
|
this one deserves a test or two... |
* add --max-output-buffer-size command line option * add --max-output-buffer-timeout command line option
|
merge me @jehiah |
jehiah
added a commit
that referenced
this pull request
Jun 1, 2013
nsqd: client configurable output buffering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm happy with how the feature negotiation stuff has gone and it makes sense for the client to be able to (optionally) control the output buffering
nsqduses to write to it for a variety of use cases.PS. I was never really happy with the fact that I had chosen a hard-coded 5ms... one size does not fit all.
cc @jayridge