nsqd: paused channel becomes unpaused when nsqd bounces #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, we "fixed" this issue originally in #114. My guess is that these nodes aren't exiting cleanly and that's a contributing factor. In Regardless, the fix is to explicitly persist metadata on channel pausing and unpausing. |
|
RFR @jehiah |
jehiah
added a commit
that referenced
this pull request
Oct 3, 2013
nsqd: paused channel becomes unpaused when nsqd bounces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen in production an issue where we have a paused channel. If one of the nsqd processes in the cluster bounces, the channel on that particular node becomes unpaused and starts processing again. The other nodes remain paused.
