nsqd: touch handling #407
Merged
nsqd: touch handling #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also, seems like we should figure out a way that TOUCH uses the client timeout as modified by identify instead of the nsqd configured timeout. |
|
We should pass in the client's timeout where it is called in Good catch... |
|
did the latter in mreiferson/nsq@5f0bcb2, can't push to your repo so cherry-pick that in |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you TOUCH a message, the logic that checks bounds on the timestamp adds the msgtimeout twice when doing the check which it shouldn't. In addition it seems that the definition of touch "reset the msg timeout" would imply it's based on Now() just like it originally is, not that it extends the previous timeout.
cc: @mreiferson