nsqadmin: dynamic graphite timeframe #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense 👍 |
| @@ -10,9 +10,9 @@ | |||
| "handlebars": "1.3.0", | |||
| "hbsfy": "1.3.2", | |||
| "browserify": "4.1.9", | |||
| "gulp-sass": "0.7.1", | |||
| "gulp-sass": "2.0.4", | |||
There was a problem hiding this comment.
I guess I had updated node at some point and this old version of gulp-sass wasn't working.
mreiferson
force-pushed
the
query_timeframe_649
branch
from
450cdd0 to
e45a6c0
Compare
|
updated @jehiah |
|
(I haven't actually tested this 😁) |
mreiferson
force-pushed
the
query_timeframe_649
branch
from
e45a6c0 to
6039f2e
Compare
|
Pushed another tweak to prefix the timeframes for the graphite URLs with |
|
@mreiferson I had to |
mreiferson
force-pushed
the
query_timeframe_649
branch
from
3c9f6b8 to
ccc8e5f
Compare
|
updated/squashed |
jehiah
added a commit
that referenced
this pull request
Sep 22, 2015
nsqadmin: dynamic graphite timeframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to #323 nsqadmin controlled the graphite integration timeframe via
?t={{timeframe}}and persisted it via cookie. Now it's persisted via browser local storage.The benefit of the previous approach is that you were not limited to the built in timeframe selection options and could pick any supported graphite time range (ie:
?t=3weeks). This also meant you could hard link other people to view the dashboard in a specific timeframe which is helpful in troubleshooting in a group setting.I think we should add the ability to select a custom timeframe (ie: a new 'other' option in the dropdown that presents a free form selection) and possibly add back the ability to pick up the timeframe option when present as a query parameter
cc: @mreiferson