nsqadmin: improve error logging #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jehiah
force-pushed
the
error_debugging_657
branch
from
86009b2 to
6e13b64
Compare
|
LGTM |
mreiferson
added a commit
that referenced
this pull request
Sep 23, 2015
nsqadmin: improve error logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves nsqadmin to show actual errors when unable to query all configured nsqd or nsqlookupd instances. Previously it left the specific error out which made it hard to troubleshoot. (@mreiferson if you'd prefer it only log the specific error i'm ok w/ that too)
This also updates the backwards compatability added in #652 to default hostname to the same value as BroadcastAddress.