nsqd: stats call times out requests during high load #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. thanks! |
jehiah
added a commit
that referenced
this pull request
Dec 31, 2015
nsqd: stats call times out requests during high load
|
😂 nice catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While maxing out (reading and writing) my local nsqd with many topics (9 in this case), I noticed calling the stats api causes all requests from my consumers and producers to timeout and the stats call, if completed, takes around 14 seconds.
I believe this is caused by unneeded locking in the GetStats method. Removing the deferred and moving the RUnlock fixes the issue. During high load the stats call remained under 2ms and the consumers and producers no longer timeout. Tested with the race detector and everything looks good.