statsd support #76
Merged
statsd support #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
work in progress |
|
ok, ready for review @jehiah |
| return errors.New("not connected") | ||
| } | ||
| stat = fmt.Sprintf(c.prefix, stat) | ||
| format = fmt.Sprintf("%s:%s", stat, format) |
There was a problem hiding this comment.
why not just add a %s to the beinning of this and remove the need to enforce that the client specifies that on the command line? (they prefix because exactly that, just a prefix).
format = fmt.Sprintf("%s%s:%s", c.prefix, stat, format)
…esponse format for /empty_channel
|
squashed |
* cleanup stats collection code to separate retrieval from formatting * add options for statsd * add statsd client * add statsdLoop that pushes diffs over UDP to a configured statsd address
* add --graphite-url command line parameter * add --use-statsd-prefix command line parameter * readme/statsd docs
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
config: normalize opt names to underscores
absolute8511
added a commit
to absolute8511/nsq
that referenced
this pull request
Jan 12, 2023
fix npe when trace log does not belong to nsqd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we'd like to support pretty charts and stats via
nsqadminwith as little built in work as possible.the simplest initial approach seems to be that
nsqdcan write UDP packets directly to astatsdnode (which eventually gets into graphite, which can then be queried by nsqadmin).in terms of the impact to the
nsqdcodebase, a lot of the foundational work would be necessary regardless of whether the output wasstatsdformat or whether it was a new command on the V2 protocol that pushed some internal format over the wire to a client.It seems that
statsdis a common and supported enough platform to build on top of.cc @jehiah