Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Adds support for alpine as base image #766

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

kenjones-cisco
Copy link
Contributor

Adds a variant for NSQ leveraging alpine as the base image.

Alpine is equally as small as busybox (~5 MB) but has more features
including the ability to install other packages.

@kenjones-cisco
Copy link
Contributor Author

busybox is unfortunately very limited as there is no option for curl and wget is all but broken. So the ability to extend the base nsqio/nsq image is painful. This provides an equally simple base image that leverages busybox binaries internally while providing the option for more if needed.

Many of the major official images within Docker Hub are now including an alpine variant or using alpine exclusively.

To maintain backwards compatibility with what existed, I just added a separate docker file and updated the dist to build a new image with a different tag indicating alpine.

@mreiferson
Copy link
Member

I would be amenable to switching the official image over to alpine, what do you think @jehiah?

cc @ploxiln

@jehiah
Copy link
Member

jehiah commented Jun 3, 2016

sounds good to me

@kenjones-cisco
Copy link
Contributor Author

Should I update the PR to replace the existing Dockerfile then?

@mreiferson
Copy link
Member

Yes please!


ADD dist/docker/bin/ /nsq_bin/
RUN cd / && ln -s /nsq_bin/* . \
&& cd /bin && ln -s /nsq_bin/* .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't drop the symlinks for backwards compat

@mreiferson
Copy link
Member

great, thanks!

Do you mind squashing this down to one commit?

Alpine is equally as small as busybox (~5 MB) but has more features
including the ability to install other packages.
@kenjones-cisco kenjones-cisco force-pushed the task/docker-alpine-base branch from 0d1275d to 80683f8 Compare June 6, 2016 18:01
@kenjones-cisco
Copy link
Contributor Author

@mreiferson done

@mreiferson
Copy link
Member

LGTM

@mreiferson mreiferson merged commit 75f215b into nsqio:master Jun 6, 2016
@kenjones-cisco kenjones-cisco deleted the task/docker-alpine-base branch July 23, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants