-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Adds support for alpine as base image #766
docker: Adds support for alpine as base image #766
Conversation
busybox is unfortunately very limited as there is no option for curl and wget is all but broken. So the ability to extend the base nsqio/nsq image is painful. This provides an equally simple base image that leverages busybox binaries internally while providing the option for more if needed. Many of the major official images within Docker Hub are now including an alpine variant or using alpine exclusively. To maintain backwards compatibility with what existed, I just added a separate docker file and updated the dist to build a new image with a different tag indicating alpine. |
sounds good to me |
Should I update the PR to replace the existing Dockerfile then? |
Yes please! |
|
||
ADD dist/docker/bin/ /nsq_bin/ | ||
RUN cd / && ln -s /nsq_bin/* . \ | ||
&& cd /bin && ln -s /nsq_bin/* . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't drop the symlinks for backwards compat
great, thanks! Do you mind squashing this down to one commit? |
Alpine is equally as small as busybox (~5 MB) but has more features including the ability to install other packages.
0d1275d
to
80683f8
Compare
@mreiferson done |
LGTM |
Adds a variant for NSQ leveraging alpine as the base image.
Alpine is equally as small as busybox (~5 MB) but has more features
including the ability to install other packages.