nsqlookupd: improve test coverage #778
Conversation
|
Initial efforts, so far but wanted to start the PR so that it is visible and if there is any feedback on the work being done that it can be shared sooner rather than later. I'll remove the [WIP] from the title once I think it is ready for merging. All feedback welcome! |
kenjones-cisco
force-pushed
the
test/improve-nsqlookupd-coverage
branch
2 times, most recently
from
1ae2c92 to
40ce04e
Compare
kenjones-cisco
changed the title
| @@ -17,10 +17,10 @@ func Equal(t *testing.T, expected, actual interface{}) { | |||
| } | |||
|
|
|||
| func NotEqual(t *testing.T, expected, actual interface{}) { | |||
| if !reflect.DeepEqual(expected, actual) { | |||
| if reflect.DeepEqual(expected, actual) { | |||
There was a problem hiding this comment.
hah, guess we didn't use that very much 😉
|
@kenjones-cisco thanks, this is really great 😍 ❤️ 💯 |
mreiferson
changed the title
kenjones-cisco
force-pushed
the
test/improve-nsqlookupd-coverage
branch
from
40ce04e to
b8deec8
Compare
|
ok, |
|
@kenjones-cisco thanks, we've been trying to slowly remove our use of It's my fault for not mentioning this earlier on this PR, but would you mind removing |
|
Sure no problem. |
kenjones-cisco
force-pushed
the
test/improve-nsqlookupd-coverage
branch
from
b8deec8 to
2143735
Compare
Adds test cases to improve code coverage to protect against potential compatibility conflicts moving forward. Existing test cases refactored to leverage common test helpers within the internal/test package to avoid code duplication and simplify the testing effort.
kenjones-cisco
force-pushed
the
test/improve-nsqlookupd-coverage
branch
from
2143735 to
231c9ef
Compare
|
Removed |
|
😍👍🏻 |
Adds test cases to improve code coverage to protect against potential
compatibility conflicts moving forward.
Existing test cases refactored to leverage common test helpers within
the internal/test package to avoid code duplication and simplify
the testing effort.