Go reader API improvements and optimization #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these changes look good. performance_improvements++ |
* buffer input and output in Go reader * deprecate SendCommand in favor of an instance method Write() on the Command type (like Message). also refactor implementation to avoid intermediate creation of slices. * DRY up code that sends RDY updates
jehiah
added a commit
that referenced
this pull request
Oct 30, 2012
Go reader API improvements and optimization
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
auto enable TLS negotation when setting other TLS options
absolute8511
added a commit
to absolute8511/nsq
that referenced
this pull request
Jan 12, 2023
Optimize meta write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add read/write buffering for the Go reader and also tweak style to be a bit more idiomatic Go cc @jehiah