nsqadmin: Fix handling of IPv6 broadcast addresses #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
requested changes
Nov 25, 2016
| @@ -77,11 +78,29 @@ func (p *Producer) Address() string { | |||
| } | |||
|
|
|||
| func (p *Producer) HTTPAddress() string { | |||
| return fmt.Sprintf("%s:%d", p.BroadcastAddress, p.HTTPPort) | |||
| return addressWithPort(p.BroadcastAddress, p.HTTPPort) | |||
There was a problem hiding this comment.
go has builtins for this, let's use net.JoinHostPort
|
@mreiferson Done. standard library FTW. |
mreiferson
approved these changes
Dec 2, 2016
|
Re-triggered those flakey test runs. In the meantime would you mind squashing down to one commit? |
|
apparently I don't know how to use git or github anymore ^^^ |
magnetised
force-pushed
the
ipv6_broadcast_addresses_815
branch
from
7f13aca to
d8e4db1
Compare
|
@magnetised thanks! |
|
@mreiferson I'd forgotten all about this - thanks for the unintentional email-storm reminder :) |
|
@mreiferson any idea when the next release is? |
Trying to get things in shape for one! |
|
@mreiferson great. good luck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815