Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix s3 tests #178

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Attempt to fix s3 tests #178

merged 1 commit into from
Aug 26, 2018

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented Aug 26, 2018

Something changed in the mocks making travis fail to mock credential fetches

@MSeal MSeal force-pushed the s3TestFix branch 3 times, most recently from ca1e464 to 4072259 Compare August 26, 2018 20:08
@MSeal
Copy link
Member Author

MSeal commented Aug 26, 2018

getmoto/moto#1793 -- boto3 changed internals which broke moto. Pinning boto3 for tests only for now...

@MSeal MSeal merged commit 7a868ae into nteract:master Aug 26, 2018
@nebi-frame
Copy link

why this pr not merged?

@MSeal
Copy link
Member Author

MSeal commented Apr 4, 2019

It was merged on Aug 26th last year... what do you mean?

@nebi-frame
Copy link

sorry my bad, but I keep getting error while using mock_s3

@MSeal
Copy link
Member Author

MSeal commented Apr 4, 2019

Try upgrading packages to the latest (or start from a fresh virtualenv) and see if it goes away.

@MSeal MSeal deleted the s3TestFix branch August 18, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants