Keep separating public and private API #2157
Conversation
IvanNardi
force-pushed
the
more-private
branch
3 times, most recently
from
40925b3 to
52ac0b7
Compare
IvanNardi
force-pushed
the
more-private
branch
from
52ac0b7 to
08d83bb
Compare
IvanNardi
force-pushed
the
more-private
branch
from
08d83bb to
bcae7fb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -2164,6 +2152,29 @@ extern "C" { | |||
| */ | |||
| void *ndpi_get_user_data(struct ndpi_detection_module_struct *ndpi_str); | |||
|
|
|||
| /* ******************************* */ | |||
|
|
|||
| /* Can't call libc functions from kernel space, define some stub instead */ | |||
There was a problem hiding this comment.
Just out of curiosity: Running nDPI in kernel space is officially supported?
There was a problem hiding this comment.
That line has been simply copied around...
I don't think that nDPI is "officially" supported in kernel-space, but the original OpenDPI was.
And, more important, there is at least one active fork https://github.com/vel21ripn/nDPI (by @vel21ripn) which, AFAIK, works in kernel-space. Since that fork is maintained and quite in sync with upstream, I think that there are no huge issues in upstream code preventing nDPI from working in kernel-mode. But I never investigate it...
There was a problem hiding this comment.
Maybe we could add a simple kernel module to examples/ and the CI so we know at least if nDPI is able to build in such environments.
See: b08c787