Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AX_PTHREAD for MingW/MSYS builds. #2338

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented Mar 6, 2024

Please sign (check) the below before submitting the Pull Request:

Link to the related issue:

Describe changes:

@utoni utoni force-pushed the fix/msys2-build branch from bf56594 to b69eefc Compare March 6, 2024 17:21
@IvanNardi
Copy link
Collaborator

@utoni, is this PR about the failing CI jobs on windows?

@utoni
Copy link
Collaborator Author

utoni commented Mar 6, 2024

It is. Somehow AX_PTHREAD fails to find winpthreads.

@utoni utoni force-pushed the fix/msys2-build branch 3 times, most recently from bac7832 to f4db032 Compare March 7, 2024 07:52
@utoni utoni changed the title Upgrade MSYS2 inside Github Actions. Disable AX_PTHREAD for MingW/MSYS builds. Mar 7, 2024
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!
BTW, do you have any idea why it stops working right now? What changes?

@utoni utoni force-pushed the fix/msys2-build branch 2 times, most recently from 672e3a4 to e4736c3 Compare March 7, 2024 09:48
configure.ac Outdated Show resolved Hide resolved
@utoni utoni force-pushed the fix/msys2-build branch 2 times, most recently from 816d333 to df5ec50 Compare March 7, 2024 11:52
@utoni utoni force-pushed the fix/msys2-build branch from df5ec50 to 2a493ad Compare March 7, 2024 11:55
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
277 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@utoni utoni merged commit 1fb4719 into ntop:dev Mar 7, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants