density_weighted_uncertainty_sampling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 86.53% (diff: 98.71%)@@ master #72 diff @@
==========================================
Files 20 21 +1
Lines 598 676 +78
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 508 585 +77
- Misses 90 91 +1
Partials 0 0
|
|
I personally think that we should better follow the design philosophy of sklearn, as most of the users are expected to be already familiar with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This active learner requires predict_proba not predict_real for libact.models.
I personally favor interface like scikit-learn, instead of dividing them to Model, ContinuousModel, ProbabilisticModel.
Discussion for interface needed.
@hsuantien @iamyuanchung