Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mine sound effect + sound effect process #40

Merged
merged 8 commits into from
Apr 4, 2023
Merged

Add mine sound effect + sound effect process #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fdc5fe4
Add checklist
nucleartide Mar 31, 2023
ea51dce
Add pickaxe sound effect
nucleartide Mar 31, 2023
a51bebc
Hook up Pickaxe Hit sound
nucleartide Mar 31, 2023
2991e42
Add magic reload thingy
nucleartide Mar 31, 2023
c84c43e
Update .gitignore
nucleartide Mar 31, 2023
441e764
Add pipeline for adding sound effects
nucleartide Mar 31, 2023
ea1a37d
Update readme
nucleartide Apr 4, 2023
8dcd3a4
Small tweak
nucleartide Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/add_sound_effect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## Pipeline

1. [ ] Find a sound effect from freesound.org. (I like this most currently, no need to download nor pay for huge asset pack.)
2. [ ] Check the sound's license to ensure that I can use it.
3. [ ] Import sound into `Sounds/` folder.
4. [ ] Update `Sounds/Attribution.md` doc. Give credit where it's due!
5. [ ] Expose new reference in the `AllTheSounds` ScriptableObject, and hook up the `AudioClip`.
6. [ ] Expose game event for when you want the sound to be played.
* For example, the `PlayerAnimationEvents` script exposes player animation events to C#.
7. [ ] Make `SoundManager` listen to the new game event, and play the corresponding sound when the event occurs.

## Alternatives

* bfxr.net
* Purchase a reputable (not stolen, like Sidearm Studios') sound effect pack on the Asset Store
* Research other methods of procuring or producing sounds on Reddit
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ Assets/Plugins/Ciathyza/
Assets/Plugins/Kevin Iglesias/
Assets/Plugins/Kevin Iglesias More/
Assets/Plugins/polyperfect/
Assets/Plugins/Ultimate SFX Bundle*

# Mac stuff.
.DS_Store
Expand All @@ -74,3 +75,6 @@ UserSettings/

# Test builds.
test_build*

# Hot Reload for Unity license. Seems like sensitive data, so don't commit.
LicenseSpring/
2 changes: 1 addition & 1 deletion Assets/Audiovisuals/Animation Controllers/Astronaut.controller
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ AnimatorState:
m_MirrorParameterActive: 0
m_CycleOffsetParameterActive: 0
m_TimeParameterActive: 0
m_Motion: {fileID: 7400000, guid: b1c4a57ece73d404f9aebbd969b9be3a, type: 3}
m_Motion: {fileID: 7400000, guid: 06319f34732b348508ddd64a63cca211, type: 2}
m_Tag:
m_SpeedParameter:
m_MirrorParameter:
Expand Down
Loading