Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ton of animation polish #54

Merged
merged 34 commits into from
Apr 13, 2023
Merged

Conversation

nucleartide
Copy link
Owner

@nucleartide nucleartide commented Apr 11, 2023

Demo

Tinny sound from OBS, but the animations are higher quality:

yep.mp4

Changelog

  • Fix: fire OnCollectCompleted and OnDepleted Resource events in a mutually exclusive manner
  • Fix: move resource collection for chopping wood to OnLateChopImpact, because there is a bug where OnLateChopImpact prevents logic in OnChopImpact from playing the chop sound effect
  • Add logging to PlayerAnimationEvents
  • Add lookahead time to Cinemachine camera, so that camera looks ahead when player is running (instead of lagging behind)
  • Tweak player configuration and animation threshold for player speed so that the walk animation cycle doesn’t look moonwalk-y
  • Remove backpack from Man Astronaut model so that it the Pick Up animation doesn’t look distorted
  • Toggle off Loop Pose checkbox on most animations, because it’s distorting the animation quality
  • Toggle off Animation Compression on most animations, because it’s distorting the animation quality (we can re-enable animation compression later with zero allowed error margin)
  • Tweak the settings of all animation clips, following the explanations on root motion laid out in https://www.youtube.com/watch?v=9bV0K-pifXE
  • Create new Pick Up animation where the feet aren’t sliding around strangely (this is huge)

Notes for future

@nucleartide nucleartide force-pushed the jason/animation-polish-fixes branch from 6633860 to 64fa5c4 Compare April 11, 2023 22:09
@nucleartide nucleartide marked this pull request as ready for review April 13, 2023 22:28
@nucleartide nucleartide changed the title Polish up animations Add a ton of animation polish Apr 13, 2023
@nucleartide nucleartide merged commit 70cb1d0 into master Apr 13, 2023
@nucleartide nucleartide deleted the jason/animation-polish-fixes branch April 13, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant