Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary and revised figure #86

Merged
merged 31 commits into from
Jun 15, 2020
Merged

Conversation

bdevans
Copy link
Collaborator

@bdevans bdevans commented Jun 13, 2020

This addresses #62, adding a summary figure of the rules, reformats the analogy figure for a consistent aesthetic and makes some associated minor changes to the text.

Hopefully this is the final PR before submission!

@bdevans bdevans mentioned this pull request Jun 13, 2020
3 tasks
@bdevans
Copy link
Collaborator Author

bdevans commented Jun 13, 2020

As mentioned, the only other change I would propose (not yet committed) is to rename Rule 2 to "Build on available images" (of which using versioned images is a natural sub-rule). The generality of the new wording would follow well from Rule 1 as they are both encouraging readers to not reinvent the wheel.

@nuest nuest mentioned this pull request Jun 14, 2020
@nuest
Copy link
Owner

nuest commented Jun 14, 2020

@bdevans Renaming Rule 2 is a good idea, I like the distinction between "use" and "build", too. Please go ahead and make that change, then we can merge and I'll submit after pinging the remaining coauthors again.

@nuest nuest self-requested a review June 14, 2020 15:47
@bdevans
Copy link
Collaborator Author

bdevans commented Jun 14, 2020

Hi @nuest, I've made the changes and slightly reworked (mostly reordered) the text for Rule 2 for a more natural flow (it might be easiest to follow from the sequence of commits rather than the aggregated changes). I've also fixed a couple of minor typos and inconsistencies.

Hopefully this is now good to go! 🚀

@nuest
Copy link
Owner

nuest commented Jun 15, 2020

Good work - I am glad you discovered (the hopefully final ones) and fixed some container/image mixups.

@nuest nuest merged commit 062cffc into nuest:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants