Refactor getThumbnail endpoint to support new indexed collection representative_image data shape #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmquinn
requested review from
mbklein and
kdid
and removed request for
mbklein
mbklein
reviewed
Feb 3, 2023
…esentative_image data shape and placeholder functionality.
bmquinn
force-pushed
the
3456-collection-rep-image
branch
from
3812322 to
d1610db
Compare
mbklein
approved these changes
Feb 3, 2023
kdid
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example collection from dev environment running both DC API / next app:
Steps to test
collections/{id}/thumbnailendpoint and you should get the placeholder image