Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github action to have 'sam deploy' read parameter overrides from .parameter files #118

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Update github action to have 'sam deploy' read parameter overrides from .parameter files #118

merged 1 commit into from
Mar 10, 2023

Conversation

bmquinn
Copy link
Contributor

@bmquinn bmquinn commented Mar 10, 2023

Description

Our parameter overrides from samconfig.toml are being clobbered by the sam deploy step in the build, so this PR modifies sam deploy to read the parameter overrides from files checked into the tfvars repository.

Changes

  • Updates deploy.yml described above
  • Updates README to include steps for manual deployment
  • Adds /*.parameters to .gitignore

Steps to test

  • Review the code as best you can, and we'll figure out if it works when it deploys.

@bmquinn
Update github action to have 'sam deploy' read parameter overrides fr…
7975667 
…om .parameter files based on deployment environment
@bmquinn bmquinn requested a review from kdid March 10, 2023 19:39
@bmquinn bmquinn merged commit 0763146 into deploy/staging Mar 10, 2023
@bmquinn bmquinn deleted the 3590-samconfig-parameter-overrides branch March 10, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdid kdid kdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmquinn @kdid