Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unattended deploy params from manual deploy instructions #120

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Mar 13, 2023

The --no-confirm-changeset and --no-fail-on-empty-changeset parameters on sam deploy are only supposed to be used on unattended deploys. When deploying manually, we do want people to review and confirm the changes that will be made before it happens.

@mbklein mbklein requested a review from kdid March 13, 2023 19:59
@mbklein mbklein merged commit f87f457 into deploy/staging Mar 13, 2023
@mbklein mbklein deleted the confirm-manual-changeset branch March 13, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants