Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure event object has expected members #33

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Oct 20, 2022

sam local and API Gateway apparently differ in how the event object is built. sam makes sure some (but not all) event properties like cookies, pathParameters, etc. exist even if they're empty. API Gateway leaves them undefined if they're not part of the request. This PR adds logic to the event-prep middleware to add them if they're missing.

Additional changes:

  • Update swagger docs to include correct query parameters
  • Add swagger entry for /works/{id}/similar

@mbklein mbklein requested a review from kdid October 20, 2022 17:42
Update swagger docs to include correct query parameters
Add swagger entry for /works/{id}/similar
@mbklein mbklein force-pushed the BUGFIX-missing-event-members branch from ec96126 to 21d2786 Compare October 20, 2022 17:43
@mbklein mbklein temporarily deployed to staging October 20, 2022 17:43 Inactive
@kdid kdid merged commit 8bbb684 into deploy/staging Oct 20, 2022
@kdid kdid deleted the BUGFIX-missing-event-members branch October 20, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants