Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIIF Manifest for Works endpoint in DC API V2 #37

Merged
merged 1 commit into from
Oct 26, 2022
Merged

IIIF Manifest for Works endpoint in DC API V2 #37

merged 1 commit into from
Oct 26, 2022

Conversation

kdid
Copy link
Contributor

@kdid kdid commented Oct 21, 2022 •
edited by adamjarling
Loading

What does this do?

Adds ?as=iiif to the end of the Work API endpoint, which returns a IIIF 3.0 Manifest.

How to test

  1. Run the DC API v2 locally
  2. In the browser, call a single Work endpoint - works/1234
  3. Add ?as=iiif to the end - works/1234?as=iiif
  4. Verify you're seeing a IIIF 3.0 manifest
  5. Validate here: https://presentation-validator.iiif.io/

@kdid kdid temporarily deployed to test October 21, 2022 19:24 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 21, 2022 19:36 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 21, 2022 19:56 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 21, 2022 20:20 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 21, 2022 20:23 Inactive
@adamjarling adamjarling temporarily deployed to test October 24, 2022 14:39 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 24, 2022 15:24 Inactive
@kdid kdid temporarily deployed to test October 24, 2022 15:58 Inactive
@adamjarling adamjarling temporarily deployed to test October 24, 2022 18:25 Inactive
@kdid kdid temporarily deployed to test October 24, 2022 19:00 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 24, 2022 19:19 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 24, 2022 19:48 Inactive
@adamjarling adamjarling temporarily deployed to test October 24, 2022 20:45 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 14:37 Inactive
@kdid kdid temporarily deployed to test October 25, 2022 15:14 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 15:43 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 15:48 Inactive
@kdid kdid temporarily deployed to test October 25, 2022 17:23 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 17:44 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 17:47 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 18:00 Inactive
@kdid kdid temporarily deployed to test October 25, 2022 18:57 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 19:32 Inactive
@mathewjordan mathewjordan temporarily deployed to test October 25, 2022 20:01 Inactive
@adamjarling adamjarling temporarily deployed to test October 26, 2022 14:55 Inactive
@kdid kdid temporarily deployed to test October 26, 2022 15:42 Inactive
@adamjarling adamjarling temporarily deployed to test October 26, 2022 18:48 Inactive
@adamjarling adamjarling temporarily deployed to test October 26, 2022 19:09 Inactive
@adamjarling adamjarling marked this pull request as ready for review October 26, 2022 19:09
mbklein
mbklein approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mbklein mbklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I was getting an error when certain fields were missing from the index, but it turned out I just had to pull meadow and reindex. Now everything is 👍

@kdid kdid changed the title 3261 as iiif IIIF Manifest for Works endpoint in DC API V2 Oct 26, 2022
@kdid
Copy link
Contributor Author

kdid commented Oct 26, 2022

I thought I was getting an error when certain fields were missing from the index, but it turned out I just had to pull meadow and reindex. Now everything is 👍

Oh yeah, sorry forgot to mention that

bmquinn
bmquinn approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kdid kdid merged commit 7661733 into deploy/staging Oct 26, 2022
@kdid kdid deleted the 3261-as-iiif branch October 26, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmquinn bmquinn bmquinn approved these changes

@mbklein mbklein mbklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kdid @mbklein @bmquinn @adamjarling @mathewjordan