Adds thumbnail to IIIF collection if it's an RDC Collection #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
requested changes
Oct 27, 2022
kdid
force-pushed
the
3249-collection-thumbnail-in-iiif-collection
branch
from
98bb529 to
df1dbf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to add the
thumbnailproperty containing the API thumbnail route for the collection (/collection/id/thumbnail) to the IIIF collection response if the request was for a RDC collection. (the request was/collections/id?as=iiifrather than/search?query=foo&as=iiif)How to test
/collections/id?as=iiifroute and look for thumbnail property/search?query=foo&as=iiifand observe that there is no thumbnail property