feat: container-type level version compatibility check #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage ? 60.41%
Complexity ? 364
=======================================
Files ? 122
Lines ? 2448
Branches ? 169
=======================================
Hits ? 1479
Misses ? 840
Partials ? 129 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Keran Yang <[email protected]>
yhl25
reviewed
Sep 26, 2024
Comment on lines
18
to
22
| FBSINKER("fb-sinker"), | ||
| UNKNOWN("unknown"); | ||
|
|
||
| private final String name; | ||
|
|
There was a problem hiding this comment.
Do we need to support UNKNOWN?
There was a problem hiding this comment.
No, I put it mainly for error scenarios.
yhl25
previously approved these changes
Sep 26, 2024
yhl25
dismissed
their stale review
As discussed, lets not go extract the container type from the server info file path. We can pass it as an argument from each component.
Signed-off-by: Keran Yang <[email protected]>
yhl25
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java version of numaproj/numaflow-go@36deadf