-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: abstract gRPC server #156
Conversation
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Server.this.stop(); | ||
log.info("gracefully shutting down event loop groups"); | ||
this.grpcServerHelper.gracefullyShutdownEventLoopGroups(); | ||
this.stop(); | ||
// FIXME - this is a workaround to immediately terminate the JVM process | ||
// The correct way to do this is to stop all the actors and wait for them to terminate | ||
System.exit(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway to get rid of hard exit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @RohanAshar . Yes, I plan to fix it very soon. I was not able to fix it this week so I decided to create an issue and fix it ASAP next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Keran Yang <[email protected]>
Closes #154
Tested by building test images and running the following pipeline for one hour with no issue. 2000 TPS.