Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp and level filter fix for logs #2374

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Jan 30, 2025

Timestamp is added to all logs from K8S API.
'All' filter will show all logs and only logs with level info / name will come under respective filter.
Fixes #2354
Fixes #2341
Fixes #2342

@veds-g veds-g requested review from whynowy and vigith as code owners January 30, 2025 03:34
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (d4e5859) to head (7480e0e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/apis/v1/handler.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   68.14%   69.70%   +1.55%     
==========================================
  Files         352      361       +9     
  Lines       46527    49935    +3408     
==========================================
+ Hits        31708    34808    +3100     
- Misses      13737    14052     +315     
+ Partials     1082     1075       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith requested a review from adarsh0728 January 30, 2025 04:09
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
@whynowy whynowy merged commit 8e9bafb into numaproj:main Jan 31, 2025
25 checks passed
@veds-g veds-g mentioned this pull request Feb 3, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants