DEVOPS-141 Prevent symbol preemption of c++ references to static stdc++ #1039
Conversation
…math, engine_internal, etc. in preparation for adding export maps.
|
By analyzing the blame information on this pull request, we identified @scottpurdy, @oxtopus and @rcrowder to be potential reviewers |
…pic.bindings shared objects. Use shared libgcc and static libstdc++ for builds of python.bindings python extension shared objects on Linux.
vitaly-krugl
force-pushed
the
devops141-stdcpp-abi-manylinux
branch
from
61d682d to
affa66e
Compare
| @@ -671,7 +671,7 @@ if (${NUPIC_BUILD_PYEXT_MODULES}) | |||
| set(CMAKE_SWIG_FLAGS ${src_swig_flags} ${CMAKE_SWIG_FLAGS}) | |||
|
|
|||
| # Set up linker flags for python extension shared libraries | |||
| set(src_swig_extension_link_flags "${PYEXT_LINKER_FLAGS_OPTIMIZED}") | |||
| set(_SRC_SWIG_EXTENSION_LINK_FLAGS "${PYEXT_LINKER_FLAGS_OPTIMIZED}") | |||
There was a problem hiding this comment.
I think I will soon have to bite the bullet and switch "private globals" to leading underscore plus all caps. Having them in lowercase is confusing when you use them inside a function, which itself uses lower-case property names locally.
Here, I started changing the few of the private module-global properties that I needed inside functions to all-caps for code readability.
vitaly-krugl
changed the title
|
Ready for code review CC @scottpurdy |
|
👍 |
| message(STATUS "src_swig_extension_link_flags= ${src_swig_extension_link_flags}") | ||
| message(STATUS "_SRC_SWIG_EXTRA_DEPS = ${_SRC_SWIG_EXTRA_DEPS}") | ||
| message(STATUS "_SRC_SWIG_LINK_LIBRARIES = ${_SRC_SWIG_LINK_LIBRARIES}") | ||
| message(STATUS "_SRC_SWIG_EXTENSION_LINK_FLAGS= ${_SRC_SWIG_EXTENSION_LINK_FLAGS}") | ||
| message(STATUS "CMAKE_SWIG_FLAGS = ${CMAKE_SWIG_FLAGS}") | ||
|
|
||
|
|
||
| function(PREPEND_BOILERPLATE_TO_PYTHON_PROXY_MODULE |
There was a problem hiding this comment.
@scottpurdy, I added this function in an earlier PR. The other day, I got a response to my question on the Swig mailing list about %pythonbegin that looks like could be used to accomplish the same feat. I filed issue #1043 as a reminder to follow up.
|
Thanks, @scottpurdy ! |
Fixes #1040
The manylinux wheel build of this PR passes all nupic.core and nupic tests (unit, integration, swarming) on Ubuntu 16.04 !!!
Use shared libgcc and static libstdc++ on linux python extension builds.
Apply an export map to OS X, Linux, and MINGW builds of nupic.bindings shared objects.
Refactor extension build steps into a function shared by algorithms, math, engine_internal, etc. in preparation for adding export maps.